Accommodate multi-digit list markers #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
The result list does not have a sufficient left margin to
accommodate list markers that are more than one digit. Because
of this, markers for results further down in the list are
truncated.
This issue exists on smaller viewports only. Larger viewports
have enough space for markers up to five digits. (This is the
maximum, in our case.)
Relevant ticket(s):
How this addresses that need:
This adds a left margin on smaller viewports to accommodate
4-digit result markers, and removes the result padding to provide
more room for text flow.
Side effects of this change:
it seems like a reasonable tradeoff for now.
affects one possible result, and it's unlikely that a user would get
to result 10,000.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
Try a broad search (I use 'data') and confirm that you can see all five digits of result marker 10000 on page 500.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing